Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Turn active_users_aggregates Looker view into a derived_table to enable parameterisation #984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kik-kik
Copy link
Contributor

@kik-kik kik-kik commented Dec 3, 2024

We should waiting for merging of this change until after 15th December due to ongoing KPI evaluations.


feat: Turn active_users_aggregates Looker view into a derived_table to enable parameterisation

Unfortunately, it appears this is the only way for us to enable a simple drop down filter on the distribution for the end user.

@kik-kik kik-kik added enhancement New feature or request looker doNotMerge labels Dec 3, 2024
@kik-kik kik-kik self-assigned this Dec 3, 2024
@bochocki
Copy link
Contributor

bochocki commented Dec 3, 2024

Is it safe to make this changes to the existing view? Is it worth considering adding a new derived_table so that we don't unintentionally impact existing Looker artifacts?

@lucia-vargas-a
Copy link
Contributor

Looker docs say that it doesn't automatically regenerate derived tables and would use cache (for ex. if no persistent is defined like in this case) which would not show real-time results (which unfortunately has been problematic in the past), To remove the risk, did you consider building a separate view for this derived table or using a PDT?

@kik-kik
Copy link
Contributor Author

kik-kik commented Dec 19, 2024

Is it safe to make this changes to the existing view? Is it worth considering adding a new derived_table so that we don't unintentionally impact existing Looker artifacts?

@bochocki so generally this should recreate what already exists. So nothing should break. The idea behind recreating this resource is that the changes automatically get applied to all existing Looker resources so no additional work is required.

There is an alternative approach that we could consider, this would include adding an additional field in the view, let's call it distribution for now. This would map to corresponding broader distribution, let's say mozilla-001 could be mapped to have value of Mozilla in the new distribution field and then we could set up field suggestions: https://cloud.google.com/looker/docs/reference/param-field-suggestions to make sure the values we want show up in the UI.

@kik-kik
Copy link
Contributor Author

kik-kik commented Dec 19, 2024

@lucia-vargas-a thanks for pointing this out. I was not aware of this Looker thing. I created a PR to pursue an alternative approach here: mozilla/bigquery-etl#6706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants